[PATCH] D23036: [SelectionDAG] Use a union of bitfield structs for SDNode::SubclassData.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 16:02:42 PDT 2016


Okay, sounds good.  I'll have a closer look when I get back from vacation
on Tuesday, please just cc me on your change.

Sorry for the trouble here.

On Aug 25, 2016 6:54 PM, "Akira Hatanaka" <ahatanak at gmail.com> wrote:

> ahatanak added a comment.
>
> Justin, I have to fix this soon since there is an internal bot that is
> failing the assert, which I suspect is happening because sizeof(SDNodeBits)
> returns 1. It doesn't look like the correctness of the code depends on
> sizeof(SDNodeBits) being equal to sizeof(unit16_t), so I'll just remove the
> assert or replace "==" with "<=".
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D23036
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160825/03d51b1c/attachment.html>


More information about the llvm-commits mailing list