[PATCH] D23889: [LV] Scalarize instructions marked scalar after vectorization

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 13:40:23 PDT 2016


mkuper added inline comments.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4550
@@ +4549,3 @@
+
+    // Scalarize instructions that should remain scalar after vectorization.
+    if (!(isa<BranchInst>(&I) || isa<PHINode>(&I)) &&
----------------
hfinkel wrote:
> mkuper wrote:
> > This scares me a bit. :-)
> > As I said on the PR, I definitely think we should do it, but it still scares me. Perhaps add a bit more testing?
> > 
> > Regardless, there's (at least?) one more special case I see below - DbgInfoIntrinsic. 
> > As I said on the PR, I definitely think we should do it, but it still scares me. Perhaps add a bit more testing?
> 
> Which PR?
My bad, not a PR, meant "on the other review". :-)
https://reviews.llvm.org/D23509


https://reviews.llvm.org/D23889





More information about the llvm-commits mailing list