[PATCH] D23617: [AMDGPU ]Refactor SOP instruction definitions.

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SOPInstructions.td:83
@@ +82,3 @@
+  opName, (outs SReg_64:$sdst), (ins), "$sdst", pattern
+> {
+  let has_src0 = 0;
----------------
> { on previous line, same everywhere else

================
Comment at: lib/Target/AMDGPU/SOPInstructions.td:97-98
@@ +96,4 @@
+  let isReMaterializable = 1, isAsCheapAsAMove = 1 in {
+    def S_MOV_B32        : SOP1_32 <"s_mov_b32">;
+    def S_MOV_B64        : SOP1_64 <"s_mov_b64">;
+  } // End isRematerializeable = 1
----------------
Can you remove the extra spaces between all the instructions and the :


https://reviews.llvm.org/D23617