[PATCH] D23833: [Polly] Introduce unittests.

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 08:44:43 PDT 2016


2016-08-24 17:03 GMT+02:00 Tobias Grosser <tobias at grosser.es>:
>> Meinersbur marked 3 inline comments as done.
>> Meinersbur added a comment.
>>
>> Out-of-tree unit tests are not easy as it requires gtest from the LLVM
>> source tree. Polly up to now only requires the LLVM_INSTALL_ROOT.
>> llvm-config can be queried for the source dir, but then we need to
>> compile gtest ourselves.
>>
>> Clang has a different approach: It requires the source tree and broadly
>> imports all cmake files such that it can use the LLVM functions to build
>> the files.
>
> We can possibly just skip them in out-of-tree builds. This is clearly
> not the most common configuration.

All the buildbots do.

To clarify: With out-of-tree builds I mean running cmake in the Polly
directory and referring to LLVM using LLVM_INSTALL_ROOT.

Michael


More information about the llvm-commits mailing list