[PATCH] D23798: [Instruction] Introduce a predicate mustOperandBeConstant()

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 06:57:46 PDT 2016


jmolloy added a comment.

Hi Sanjay,

I agree with splitting the patches prior to commit.

I didn't remove the duplicate asserts because I thought it'd be very strange coding style to downcast and then not check the result of that downcast in a verifier, even if that is also checked elsewhere. I'm open to input on this though.

James


Repository:
  rL LLVM

https://reviews.llvm.org/D23798





More information about the llvm-commits mailing list