[PATCH] D23809: ADT: Give ilist<T>::reverse_iterator a handle to the current node

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 17:12:13 PDT 2016


dexonsmith added a comment.

Justin Bogner pointed out offline that my code update table was wrong (backwards) for reverse_iterator=>iterator conversions.  I fixed the table both on Phab and in my local commit message to this table:

            [Old]         ==>          [New]
    reverse_iterator(I)         ++I.getReverse()
  --reverse_iterator(I)           I.getReverse()
    reverse_iterator(++I)         I.getReverse()
          RI.base()            ++RI.getReverse()
        --RI.base()              RI.getReverse()
      (++RI).base()              RI.getReverse()
  delete &*RI, RE = end()         delete &*RI++
  RI->erase(), RE = end()         RI++->erase()


https://reviews.llvm.org/D23809





More information about the llvm-commits mailing list