[PATCH] D23614: [PPC] Generate positive FP zero using xor insn instead of loading from constant area

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 11:31:02 PDT 2016


amehsan added a comment.

In https://reviews.llvm.org/D23614#519255, @amehsan wrote:

> In https://reviews.llvm.org/D23614#519175, @hfinkel wrote:
>
> > It does not need to be in the same commit as adds this scalar support, but we should also add a pattern to catch the vector > case. For
>
>
> Yes. I intentionally left it out because it required some extra work and I wanted to look at other issues that my reduced testcase for Eigen revealed. I will open a bugzilla item with your example.


I took a look. It seems to be a simple oversight for double and long long. For other cases we generate vxor. So changing it to generate vxor for the missing two cases is easy. I leave changing it to exploit xxlxor, for the future.


https://reviews.llvm.org/D23614





More information about the llvm-commits mailing list