[PATCH] D23036: [SelectionDAG] Use a union of bitfield structs for SDNode::SubclassData.

[Chandler Carruth via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Two tiny points below but LGTM with those fixed. Thanks for doing this it's a huge improvement!


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:279
@@ -278,1 +278,3 @@
 
+  // Build a synthetic SDNodeT with the given args and extract its subclass data
+  // as an integer (e.g. for use in a folding set).
----------------
Three slashes for doxygen

================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:286
@@ +285,3 @@
+  template <typename SDNodeT, typename... ArgTypes>
+  uint16_t getSyntheticNodeSubclassData(unsigned IROrder, ArgTypes &&... Args) {
+    // The compiler can reduce this expression to a constant iff we pass an
----------------
Make this static?


https://reviews.llvm.org/D23036