[PATCH] D23749: [NVPTX] Add NVPTXHoistAddrSpaceCast pass.

[Justin Lebar via llvm-commits]

jlebar added a comment.

In https://reviews.llvm.org/D23749#522454, @jingyue wrote:

> LGTM after you address David's comment -- A post-dominates B doesn't guarantee execution that reaches B will arrive A.


Per my last mail on the list (*), I'm not convinced this is the right approach given the limitations to hoisting that you and David point out.  We won't be able to hoist in a lot of situations that seem like they'll be common.

I gave a few alternatives in that mail.  I got one of them, teaching SCEV to treat NVPTX addrspacecasts as ptr + offset, to maybe work this afternoon.  I'm cleaning it up, will send it out soon.

(*) Do you have any idea why only some emails to the mailing list show up in phab?  Having discussions in two places seems extremely broken, but here we are.


https://reviews.llvm.org/D23749