[PATCH] D23790: [asan] Fix OOB_char on arm 32bit

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 19:38:09 PDT 2016


vitalybuka created this revision.
vitalybuka added a reviewer: krasin.
vitalybuka added a subscriber: llvm-commits.
Herald added subscribers: samparker, kubabrecka, rengolin, aemerson.

This does not actually fixes the test.
AddressSanitizer::OOB_char behavior is inconsistent and but it somehow usually
works. On arm it runs more interations then expected. And adding a new test with AddressSanitizerInterface prefix breaks OOB_char test.
So I will rename my test to make the bot gree and will continue to investigate the test.

https://reviews.llvm.org/D23790

Files:
  lib/asan/tests/asan_internal_interface_test.cc

Index: lib/asan/tests/asan_internal_interface_test.cc
===================================================================
--- lib/asan/tests/asan_internal_interface_test.cc
+++ lib/asan/tests/asan_internal_interface_test.cc
@@ -13,7 +13,7 @@
 #include "asan_interface_internal.h"
 #include "asan_test_utils.h"
 
-TEST(AddressSanitizerInterface, SetShadow) {
+TEST(AddressSanitizerInternalInterface, SetShadow) {
   std::vector<char> buffer(17, 0xff);
 
   __asan_set_shadow_00((uptr)buffer.data(), buffer.size());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23790.68946.patch
Type: text/x-patch
Size: 514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160823/624e0f3c/attachment.bin>


More information about the llvm-commits mailing list