[PATCH] D23723: [SLP] Avoid signed integer overflow

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 15:59:15 PDT 2016


mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

This LGTM except for the name. :-)

I think the name shouldVectorizeTree() implies that if true, we will vectorize - while in fact, we still need to pass the cost check.
I'd say either (a) rename it to something more explicit (something that references the fact we're checking whether the tree is tiny), or (b) have a single function to perform both the "tininess" check and the cost check.


https://reviews.llvm.org/D23723





More information about the llvm-commits mailing list