[PATCH] D23750: [ELF] Define __ehdr_start symbol

[Petr Hosek via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL279452: [ELF] Define __ehdr_start symbol (authored by phosek).

Changed prior to commit:
  https://reviews.llvm.org/D23750?vs=68798&id=68894#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D23750

Files:
  lld/trunk/ELF/Symbols.h
  lld/trunk/ELF/Writer.cpp
  lld/trunk/test/ELF/ehdr_start.s
  lld/trunk/test/ELF/linkerscript/linkerscript-ehdr_start.s

Index: lld/trunk/test/ELF/ehdr_start.s
===================================================================
--- lld/trunk/test/ELF/ehdr_start.s
+++ lld/trunk/test/ELF/ehdr_start.s
@@ -0,0 +1,11 @@
+# REQUIRES: x86
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+# RUN: ld.lld %t.o -o %t
+# RUN: llvm-objdump -t %t | FileCheck %s
+# CHECK: 0000000000010040 *ABS* 00000000 .hidden __ehdr_start
+
+.text
+.global _start, __ehdr_start
+_start:
+	.quad __ehdr_start
Index: lld/trunk/test/ELF/linkerscript/linkerscript-ehdr_start.s
===================================================================
--- lld/trunk/test/ELF/linkerscript/linkerscript-ehdr_start.s
+++ lld/trunk/test/ELF/linkerscript/linkerscript-ehdr_start.s
@@ -0,0 +1,11 @@
+# REQUIRES: x86
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+# RUN: echo "SECTIONS { }" > %t.script
+# RUN: not ld.lld %t.o -script %t.script -o %t 2>&1 | FileCheck %s
+# CHECK: undefined symbol: __ehdr_start
+
+.text
+.global _start, __ehdr_start
+_start:
+	.quad __ehdr_start
Index: lld/trunk/ELF/Symbols.h
===================================================================
--- lld/trunk/ELF/Symbols.h
+++ lld/trunk/ELF/Symbols.h
@@ -366,6 +366,9 @@
 // Some linker-generated symbols need to be created as
 // DefinedRegular symbols.
 template <class ELFT> struct ElfSym {
+  // The content for __ehdr_start symbol.
+  static DefinedRegular<ELFT> *EhdrStart;
+
   // The content for _etext and etext symbols.
   static DefinedRegular<ELFT> *Etext;
   static DefinedRegular<ELFT> *Etext2;
@@ -382,6 +385,7 @@
   static SymbolBody *MipsGpDisp;
 };
 
+template <class ELFT> DefinedRegular<ELFT> *ElfSym<ELFT>::EhdrStart;
 template <class ELFT> DefinedRegular<ELFT> *ElfSym<ELFT>::Etext;
 template <class ELFT> DefinedRegular<ELFT> *ElfSym<ELFT>::Etext2;
 template <class ELFT> DefinedRegular<ELFT> *ElfSym<ELFT>::Edata;
Index: lld/trunk/ELF/Writer.cpp
===================================================================
--- lld/trunk/ELF/Writer.cpp
+++ lld/trunk/ELF/Writer.cpp
@@ -598,6 +598,8 @@
   if (ScriptConfig->HasContents)
     return;
 
+  ElfSym<ELFT>::EhdrStart = Symtab<ELFT>::X->addIgnored("__ehdr_start");
+
   auto Define = [this](StringRef S, DefinedRegular<ELFT> *&Sym1,
                        DefinedRegular<ELFT> *&Sym2) {
     Sym1 = Symtab<ELFT>::X->addIgnored(S, STV_DEFAULT);
@@ -1180,6 +1182,10 @@
 // to each section. This function fixes some predefined absolute
 // symbol values that depend on section address and size.
 template <class ELFT> void Writer<ELFT>::fixAbsoluteSymbols() {
+  // __ehdr_start is the location of program headers.
+  if (ElfSym<ELFT>::EhdrStart)
+    ElfSym<ELFT>::EhdrStart->Value = Out<ELFT>::ProgramHeaders->getVA();
+
   auto Set = [](DefinedRegular<ELFT> *S1, DefinedRegular<ELFT> *S2, uintX_t V) {
     if (S1)
       S1->Value = V;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23750.68894.patch
Type: text/x-patch
Size: 2882 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160822/5e651324/attachment.bin>