[PATCH] D15537: limit the number of instructions per block examined by dead store elimination

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 11:28:46 PDT 2016


+philip because he expressed concerns around limiting

+eli

Eli, i think your patch to DSE to do exact may-throw tracking is what made
this worse.

https://llvm.org/bugs/show_bug.cgi?id=29064

I'm not sure we should limit DSE.

I have an analysis pass just about ready to do the EBB/maythrow stuff,
which gives "some" may-throw tracking, just not as exact as is being done
here.
Rather than limit DSE, i think we should revert the more-exact tracking for
now unless we can show it produces significant perf improvements.

Thoughts?



On Mon, Aug 22, 2016 at 10:59 AM, David Li <davidxl at google.com> wrote:

> davidxl added a comment.
>
> The patch fixes the issue in https://llvm.org/bugs/show_bug.cgi?id=29064
>
>
> https://reviews.llvm.org/D15537
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160822/59cb3662/attachment.html>


More information about the llvm-commits mailing list