[PATCH] D23603: [ELF] - Linkerscript: merge section attributes when create output section.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 02:00:52 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:300
@@ -287,2 +299,3 @@
         OutSec->addSection(Sec);
+      updateFlags<ELFT>(OutSec, V);
     }
----------------
V is a `std::vector<InputSectionBase<ELFT> *>`, but

================
Comment at: ELF/LinkerScript.cpp:316
@@ -302,2 +315,3 @@
       OutSec->addSection(S);
+      updateFlags<ELFT>(OutSec, S);
     }
----------------
S is a `InputSectionBase<ELFT> *`. How does it work?


https://reviews.llvm.org/D23603





More information about the llvm-commits mailing list