[PATCH] D23751: [ELF] Linkerscript: define symbols outside SECTIONS

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 21 21:55:48 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:274-278
@@ -263,7 +273,7 @@
   for (const std::unique_ptr<BaseCommand> &Base1 : Opt.Commands) {
     if (auto *Cmd = dyn_cast<SymbolAssignment>(Base1.get())) {
       if (shouldDefine<ELFT>(Cmd))
         addRegular<ELFT>(Cmd);
       continue;
     }
 
----------------
Now this can be removed, no?


https://reviews.llvm.org/D23751





More information about the llvm-commits mailing list