[llvm] r278010 - GVN-hoist: enable by default

[Vasileios Kalintiris via llvm-commits]

Hi Sebastian,

This broke the MIPS buildbots that do recursive builds. Could you revert the commit until we figure out what is causing the problem?

The problem is that 2 instructions from a single object file appear in the opposite order between Phase2 and Phase3.

Thanks,
Vasileios

________________________________________
From: llvm-commits [llvm-commits-bounces at lists.llvm.org] on behalf of Sebastian Pop via llvm-commits [llvm-commits at lists.llvm.org]
Sent: 08 August 2016 15:46
To: llvm-commits at lists.llvm.org
Subject: [llvm] r278010 - GVN-hoist: enable by default

Author: spop
Date: Mon Aug  8 09:46:15 2016
New Revision: 278010

URL: http://llvm.org/viewvc/llvm-project?rev=278010&view=rev
Log:
GVN-hoist: enable by default

Modified:
    llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
    llvm/trunk/test/Feature/optnone-opt.ll

Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=278010&r1=278009&r2=278010&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Mon Aug  8 09:46:15 2016
@@ -138,8 +138,8 @@ static cl::opt<int> PreInlineThreshold(
              "(default = 75)"));

 static cl::opt<bool> EnableGVNHoist(
-    "enable-gvn-hoist", cl::init(false), cl::Hidden,
-    cl::desc("Enable the experimental GVN Hoisting pass"));
+    "enable-gvn-hoist", cl::init(true), cl::Hidden,
+    cl::desc("Enable the GVN hoisting pass (default = on)"));

 PassManagerBuilder::PassManagerBuilder() {
     OptLevel = 2;

Modified: llvm/trunk/test/Feature/optnone-opt.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/optnone-opt.ll?rev=278010&r1=278009&r2=278010&view=diff
==============================================================================
--- llvm/trunk/test/Feature/optnone-opt.ll (original)
+++ llvm/trunk/test/Feature/optnone-opt.ll Mon Aug  8 09:46:15 2016
@@ -41,6 +41,7 @@ attributes #0 = { optnone noinline }
 ; OPT-O1-DAG: Skipping pass 'Combine redundant instructions'
 ; OPT-O1-DAG: Skipping pass 'Dead Store Elimination'
 ; OPT-O1-DAG: Skipping pass 'Early CSE'
+; OPT-O1-DAG: Skipping pass 'Early GVN Hoisting of Expressions'
 ; OPT-O1-DAG: Skipping pass 'Jump Threading'
 ; OPT-O1-DAG: Skipping pass 'MemCpy Optimization'
 ; OPT-O1-DAG: Skipping pass 'Reassociate expressions'


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits