[PATCH] D23721: [gold/ThinLTO] Restore ThinLTO file management in gold plugin

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 17:09:58 PDT 2016


tejohnson added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:833
@@ -825,1 +832,3 @@
+      HandleToInputFile.insert(std::make_pair(
+          F.leader_handle, llvm::make_unique<PluginInputFile>(F.handle)));
     const void *View = getSymbolsAndView(F);
----------------
mehdi_amini wrote:
> Fo you need a map here? Can't you just push back to a vector?
This is necessary for correct file locking when we have archives. See the first part of the summary for r270814. Specifically, ensure we only attempt to lock and unlock the underlying archive file once.


https://reviews.llvm.org/D23721





More information about the llvm-commits mailing list