[llvm] r279278 - GlobalISel: support overflow arithmetic intrinsics.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 19 16:43:59 PDT 2016


> On Aug 19, 2016, at 2:35 PM, Tim Northover <tnorthover at apple.com> wrote:
> 
>> I haven’t commented on that on the other patches, but I would prefer we avoid the {} notation for constructor because this is not consistent with the rest of the LLVM codebase as far as I can tell. I.e., we use ().
> 
> Well, it's only been around since C++11 so you wouldn't expect it in much of the code. But I think it provides useful sanity checks over the old syntax (implicit conversions are disallowed so you won't get away with "ObjWithShortConstructor obj{MyLong}").
> 
> It's also explicitly called out as an allowed C++11 feature in our list (http://llvm.org/docs/CodingStandards.html, "Initializer Lists”).

If that’s explicitly allowed, maybe we should move all GlobalISel constructor to use it then.
We will NFC as we touch the surrounding code :).

> 
> (BTW: octane.bc translates now!)

Yay!

> 
> Tim.



More information about the llvm-commits mailing list