[PATCH] D23654: [CMake] Rename back SIMPLE_SOURCE to compile as C++

Jonas Hahnfeld via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 23:51:01 PDT 2016


Hahnfeld added a comment.

In https://reviews.llvm.org/D23654#520383, @compnerd wrote:

> The sanitizers definitely need the unwind tables on ARM.  They are needed for the stack trace.  I don't know off the top of my head if the sanitizers use exceptions.  But, for the C++ compiler test, I think thats reasonable.  If you are doing static runtime builds, the library need not be present at runtime compile time.


That sounds like a weird setup and in the current state a much more common scenario is broken: Most of the systems will have the same libraries at runtime as they have at configure and compile time.

I insist on my main point: We must test the C++ compiler on configure time if we use it at build time and that's really the case here. Do you have a suggestion of a C++ test that would also work in your setup?


https://reviews.llvm.org/D23654





More information about the llvm-commits mailing list