[PATCH] D23649: [ADT] Change the range-based for loop in DFS to normal loop. NFC.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 23:02:05 PDT 2016


timshen added a comment.

In https://reviews.llvm.org/D23649#520437, @dberris wrote:

> (Replying here because the comments on the mailing list don't seem to get reflected in Phab)
>
> I think what confused me asking for a test case was that it wasn't clear from the description what exactly is being "fixed" (because of the word "correct").
>
> I think a comment in the code would help explain why you're doing this instead of using a range-based loop, and an update to the description would be really helpful.


Done. Sorry for the confusion!


https://reviews.llvm.org/D23649





More information about the llvm-commits mailing list