[PATCH] D22512: Added hash_stream class for producing hash codes from data streams.

[Raphael Isemann via llvm-commits]

teemperor abandoned this revision.
teemperor added a comment.

Thanks for the tips and the review!

I think the main reason why this backend is used because the code evolved from the similar functionality in Stmt::Profile which also uses this backend. We didn't look into alternatives (at least not that I'm aware of). But there is currently no performance data set that would justify any need for using CityHash over some other implementation, so I moved the clone detection to MD5 for the time being.

And we actually wanted just hashes in the clone detector as generating a good fingerprint for every AST node would be a tough requirement for the user. It's more intended as a fast value for first good guess about what nodes belong together.

I'll abandon this patch unless someone else has any need for it or we do some performance testing that actually suggests to use CityHash.


https://reviews.llvm.org/D22512