[PATCH] D23688: AMDGPU/SI: Implement a custom MachineSchedStrategy

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 12:19:04 PDT 2016


arsenm added a comment.

I think you forgot to add the new file


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:110-117
@@ -101,6 +109,10 @@
 
 static MachineSchedRegistry
 SISchedRegistry("si", "Run SI's custom scheduler",
                 createSIMachineScheduler);
 
+static MachineSchedRegistry
+GCNSchedRegistry("gcn", "Run GCN custom scheduler",
+                 createGCNMachineScheduler);
+
 static StringRef computeDataLayout(const Triple &TT) {
----------------
I think the naming here is too confusing. I think both schedulers need new names


https://reviews.llvm.org/D23688





More information about the llvm-commits mailing list