[PATCH] D23560: [RISCV 3/10] Add stub backend

James Y Knight via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 10:56:45 PDT 2016


jyknight added inline comments.

================
Comment at: lib/Target/RISCV/RISCVTargetMachine.cpp:40
@@ +39,3 @@
+  if (!RM.hasValue())
+    return Reloc::PIC_;
+  return *RM;
----------------
Default model is expected to be PIC instead of static? That's different from most general purpose targets. Perhaps deserves a comment? Or a note in the nonexistent psABI doc. :)


https://reviews.llvm.org/D23560





More information about the llvm-commits mailing list