[PATCH] D23675: [LLVM] Fix some Clang-tidy modernize-use-using and Include What You Use warnings

Eugene Zelenko via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 10:38:17 PDT 2016


Eugene.Zelenko added a comment.

I'll try to not forget to include full diff. However, I don't understand why Differential could not do this itself. After all base version is included into diff :-)


================
Comment at: include/llvm/Bitcode/BitstreamReader.h:33
@@ -24,2 +32,3 @@
+#include <utility>
 #include <vector>
 
----------------
mehdi_amini wrote:
> Can you confirm: all these extra headers are for things needed by the current header but are included transitively right now?
Yes, all added headers are really used. I always check IWYU warnings manually.


Repository:
  rL LLVM

https://reviews.llvm.org/D23675





More information about the llvm-commits mailing list