[PATCH] D22667: [mips][microMIPS] Implement BLTZC, BLEZC, BGEZC and BGTZC instructions, fix disassembly and add operand checking to existing B<cond>C implementations

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 08:08:16 PDT 2016


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with the highlighted comment changed.


================
Comment at: lib/Target/Mips/Disassembler/MipsDisassembler.cpp:2424
@@ -2326,3 +2423,3 @@
   //    0b000110 ttttt sssss iiiiiiiiiiiiiiii
   //      Invalid        if rs == 0
   //      BLEZALC_MMR6   if rs == 0  && rt != 0
----------------
if rs == 0 -> if rt == 0


https://reviews.llvm.org/D22667





More information about the llvm-commits mailing list