[PATCH] D23163: [AVX512][FastISel] Do not use K registers in TEST instructions
    Igor Breger via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Aug 18 04:31:57 PDT 2016
    
    
  
igorb added inline comments.
================
Comment at: lib/Target/X86/X86FastISel.cpp:2039
@@ +2038,3 @@
+          .addReg(CondReg)
+          .addReg(CondReg);
+    else
----------------
could you please check if this one should be addReg(CondReg, getKillRegState(CondIsKill)) ?
================
Comment at: lib/Target/X86/X86FastISel.cpp:2220
@@ +2219,3 @@
+          .addReg(CondReg)
+          .addReg(CondReg);
+    else
----------------
could you please check if this one should be addReg(CondReg, getKillRegState(CondIsKill))?
https://reviews.llvm.org/D23163
    
    
More information about the llvm-commits
mailing list