[PATCH] D23625: [Analysis] Change several Analysis pieces to use NodeRef. NFC.

[David Blaikie via llvm-commits]

dblaikie added inline comments.

================
Comment at: include/llvm/Analysis/RegionIterator.h:35
@@ -34,3 @@
-class RNSuccIterator : public std::iterator<std::forward_iterator_tag,
-                                           NodeType, ptrdiff_t> {
-  typedef std::iterator<std::forward_iterator_tag, NodeType, ptrdiff_t> super;
----------------
If it has to be a pointer type anyway - would it be simpler to preserve that behavior of value_type being a pointer rather than a value? Or is there something else going on here as well that makes this change necessary/useful?


https://reviews.llvm.org/D23625