[PATCH] D23601: [TII] add new target hook isAdd

[Quentin Colombet via llvm-commits]

qcolombet added a subscriber: qcolombet.
qcolombet added a comment.

Hi,

If we start adding more semantic of the instructions to TargetInstrInfo, I think we need to think more broadly on how to do that. Otherwise, I am afraid the API will not be consistent on the long run. E.g., why would we have isAdd and not isSub?
To be fair, the API is probably already broken, but there is not bad time to start fixing the problems :).

I am supportive of the idea of adding semantic, I am not convince a bunch of target hooks is necessarily the best approach or at least, having to populate those target hooks by hand.
At the very least, we should be able to annotate the instruction with isAdd in the td file and generate the hook in tablegen.

Cheers,
-Quentin


https://reviews.llvm.org/D23601