[PATCH] D23629: Make llvm-pdbdump print column info when available

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 16:07:56 PDT 2016


amccarth updated this revision to Diff 68445.
amccarth added a comment.

Formatting fixed.  (git clang-format isn't happy that my default version of Python is 3.x)


https://reviews.llvm.org/D23629

Files:
  tools/llvm-pdbdump/CompilandDumper.cpp

Index: tools/llvm-pdbdump/CompilandDumper.cpp
===================================================================
--- tools/llvm-pdbdump/CompilandDumper.cpp
+++ tools/llvm-pdbdump/CompilandDumper.cpp
@@ -76,6 +76,15 @@
         if (LineStart != LineEnd)
           WithColor(Printer, StatementColor).get() << " - " << LineEnd;
 
+        uint32_t ColumnStart = Line->getColumnNumber();
+        uint32_t ColumnEnd = Line->getColumnNumberEnd();
+        if (ColumnStart != 0 || ColumnEnd != 0) {
+          Printer << ", Column: ";
+          WithColor(Printer, StatementColor).get() << ColumnStart;
+          if (ColumnEnd != ColumnStart)
+            WithColor(Printer, StatementColor).get() << " - " << ColumnEnd;
+        }
+
         Printer << ", Address: ";
         if (Line->getLength() > 0) {
           uint64_t AddrStart = Line->getVirtualAddress();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23629.68445.patch
Type: text/x-patch
Size: 862 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160817/bdb90433/attachment.bin>


More information about the llvm-commits mailing list