[PATCH] D23516: [ARM] Generate consistent frame records for Thumb2

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 09:39:24 PDT 2016


On 17 August 2016 at 06:54, Oliver Stannard <oliver.stannard at arm.com> wrote:
> However, what about the  checks that enable the split push/pop, in ARMSubtarget::splitFramePushPop

I'd say this should be determined solely by whether a frame pointer is
required and is r7. That's the only situation when it's a benefit.

> and ARMBaseRegisterInfo::getCalleeSavedRegs?

I think this is correct. I would hope our bare metal targets (which we
intend to be AAPCS) pick up CSR_AAPCS_SplitPush when a frame pointer
is around.

Might be an idea to rename CSR_iOS to CSR_Darwin though now that we
have watchOS. I'll try to remember to do that.

Tim.


More information about the llvm-commits mailing list