[PATCH] D23558: [RISCV 2/10] Add RISC-V ELF defines

Alex Bradbury via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 00:14:49 PDT 2016


asb added inline comments.

================
Comment at: include/llvm/Support/ELFRelocs/RISCV.def:1
@@ +1,2 @@
+
+#ifndef ELF_RELOC
----------------
Eugene.Zelenko wrote:
> Please insert copyrights header. See other .def files as example.
Hi Eugene, I've actually followed the lead of all the other include/llvm/Support/ELFRelocs/*.def files in this case, none of which contain a copyright header in the current llvm HEAD. You're right that other .def files elsewhere in the tree seem to have such a header.


https://reviews.llvm.org/D23558





More information about the llvm-commits mailing list