[PATCH] D23036: [SelectionDAG] Use a union of bitfield structs for SDNode::SubclassData.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 21:03:28 PDT 2016


jlebar updated this revision to Diff 68302.
jlebar added a comment.

Get rid of getters/setters entirely.

FWIW I'm not totally wild about this, because the assertions are verbose.  It
brings me back to the earlier idea in https://reviews.llvm.org/D23035 of using a macro to combine the
assignment and assertion.

But I'm happy to leave this how it is too.


https://reviews.llvm.org/D23036

Files:
  llvm/include/llvm/CodeGen/SelectionDAGNodes.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23036.68302.patch
Type: text/x-patch
Size: 18673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160817/18d6e237/attachment.bin>


More information about the llvm-commits mailing list