[PATCH] D23542: [LTO] Introduce an Output class to wrap the output stream creation (NFC)

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

Will give the changes a try and report back.


================
Comment at: tools/gold/gold-plugin.cpp:657
@@ -658,3 +656,3 @@
     std::error_code EC =
         sys::fs::createTemporaryFile("lto-llvm", "o", FD, NewFilename);
     if (EC)
----------------
mehdi_amini wrote:
> tejohnson wrote:
> > FD was not declared, which exposes an issue - the interface needs to handle this being a temp file that we create here.
> Does it? Can't we just not create the file open?
Ah, yes, that should be fine. Missed the fact that createTemporaryFile will return the new filename.


https://reviews.llvm.org/D23542