[PATCH] D23328: AMDGPU: Update AMDGPURuntimeMetadata.h for enums of address space qualifiers

Yaxun Liu via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 12:47:43 PDT 2016


yaxunl added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPURuntimeMetadata.h:136-141
@@ -135,1 +135,8 @@
+
+    enum AddressSpaceQualifer : uint8_t {
+      Private    = 0,
+      Global     = 1,
+      Constant   = 2,
+      Local      = 3,
+    };
   } // namespace KernelArg
----------------
arsenm wrote:
> Should probably have the values for flat and region
This is for OpenCL kernel argument reflection. flat and region address spaces do not show up in kernel arguments.


https://reviews.llvm.org/D23328





More information about the llvm-commits mailing list