[PATCH] D23410: [SLP] Initialize VectorizedValue when gathering

[Michael Kuperstein via llvm-commits]

mkuper added inline comments.

================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2178
@@ +2177,3 @@
+
+  // If BB hasn't been scheduled, we will need to find the last instruction by
+  // brute force. We iterate forwards from front (inclusive) until we either
----------------
Could you please change this to be something like

```
} else {
 // If BB hasn't...
...
}
```
?

The dangling else really bugs me. :-)

================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2178
@@ +2177,3 @@
+
+  // If BB hasn't been scheduled, we will need to find the last instruction by
+  // brute force. We iterate forwards from front (inclusive) until we either
----------------
mkuper wrote:
> Could you please change this to be something like
> 
> ```
> } else {
>  // If BB hasn't...
> ...
> }
> ```
> ?
> 
> The dangling else really bugs me. :-)
Also, how can it happen that the BB hasn't been scheduled?
I thought this only gets called from within vectorizeTree(), which calls scheduleBlock() first?


https://reviews.llvm.org/D23410