[PATCH] D23282: [IR/GlobalISel] move compare predicates into lib/Support

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 11:40:54 PDT 2016


mehdi_amini added a comment.

I don't make sense of hosting these definitions in libSupport.

I think you are creating actually a dependency from GlobalISel to the IR as soon as you want a one-to-one mapping like that and reuse the list.
Just moving it in a separate library just for the purpose of not including llvm/IR/ seems like very artificial to me, and "breaks" the dependency on the surface.


Repository:
  rL LLVM

https://reviews.llvm.org/D23282





More information about the llvm-commits mailing list