[PATCH] D23432: [AliasSetTracker] Degrade AliasSetTracker results when may-alias sets get too large.

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/Analysis/AliasSetTracker.cpp:297
@@ +296,3 @@
+  if (AliasAnyAS) {
+    // Update the data structure, for the sake of consistency.
+    // Note that we will never need a merge here, since there's only one
----------------
Ok. Please add a little more comments here: something like 'AST is saturated at this point, .."

================
Comment at: lib/Analysis/AliasSetTracker.cpp:301
@@ +300,3 @@
+    if (Entry.hasAliasSet())
+      Entry.updateSizeAndAAInfo(Size, AAInfo);
+    else
----------------
Add assert that aliasSet of Entry is indeed AliasAnyAS.

================
Comment at: lib/Analysis/AliasSetTracker.cpp:532
@@ +531,3 @@
+  std::vector<AliasSet *> ASVector;
+  ASVector.reserve(SaturationThreshold);
+  for (iterator I = begin(), E = end(); I != E; I++)
----------------
assert AliasAnyAS is null and may alias set size has reached threshold.


https://reviews.llvm.org/D23432