[PATCH] D23510: MachineScheduler: Restore TopCand after comparing top and bottom candidates

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 10:23:06 PDT 2016


tstellarAMD added a comment.

In https://reviews.llvm.org/D23510#515568, @MatzeB wrote:

> Actually I am not so sure anymore. In cases where the topnode isn't picked the reason shouldn't matter, but we will reset the reason anyway next round when we compare against the top node again. Do you have an example that behaves differently with/without this patch? There may be something else wrong.


pickNodeBidirectional() won't re-compare if topnode wasn't scheduled in the previous round.


https://reviews.llvm.org/D23510





More information about the llvm-commits mailing list