[PATCH] D23505: [ELF] - Linkrscript: change the way of creating PT_LOADs segments when LS is used.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 04:04:03 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D23505#516380, @evgeny777 wrote:

> > Nope. Why some binary would work fine ?
>
>
> Well at least it will be loaded by the kernel. I didn't mean actual result of execution.


I guess since this patch looks the same with ld, it should solve whole problem, but not the part.

> > End of first load is :

> 

> 

> That's the problem, yes, but initially you talked about "aligning to memory page", not overlapping. May be just adding one page to 

>  3rd segment VA will fix the problem, no?


That option is mentioned in the end of description of the patch. And in one of my comments above ("will create more loads and waste more VA space").
Looks we might need 2M memory page size (https://reviews.llvm.org/D23352) and creating tons of loads does not look a good option for me.


https://reviews.llvm.org/D23505





More information about the llvm-commits mailing list