[PATCH] D23505: [ELF] - Linkrscript: change the way of creating PT_LOADs segments when LS is used.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 16 01:11:47 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D23505#515896, @ruiu wrote:

> If you think the new behavior you are implementing in this patch simpler than the current one, why don't you just replace it with the new one, instead of keeping two different functions?


I just checked what will happen if I leave only this implementation for all (for non-scripted case) and had 187 testcases fails.

Current patch changes logic only for scripted case and already had to modify 20 testcases. We probably can land it first and check if it satisfies our needs
generally for scripted path before trying to change all 187 testcases for non-scripted one.


https://reviews.llvm.org/D23505





More information about the llvm-commits mailing list