[PATCH] D21982: [compiler-rt][XRay] Initial per-thread inmemory logging implementation

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: include/xray/xray_records.h:39-42
@@ +38,6 @@
+
+  // What follows are a set of flags that indicate useful things for when
+  // reading the data in the file.
+  bool ConstantTSC : 1;
+  bool NonstopTSC : 1;
+
----------------
You could gain another byte for `Padding` by sending this between `Type` and `CycleFrequency`.

================
Comment at: lib/xray/xray_inmemory_log.cc:70
@@ +69,3 @@
+  auto BytesToRead = std::distance(Begin, End);
+  int BytesRead;
+  while ((BytesRead = read(Fd, Begin, BytesToRead)) < 0) {
----------------
`ssize_t`?


https://reviews.llvm.org/D21982