[PATCH] D23537: [LTO] Simplify APIs and constify (NFC)

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 22:57:34 PDT 2016


mehdi_amini added inline comments.

================
Comment at: include/llvm/Transforms/IPO/FunctionImport.h:117
@@ -116,3 +116,3 @@
     const StringMap<GVSummaryMapTy> &ModuleToDefinedGVSummaries,
-    const StringMap<FunctionImporter::ImportMapTy> &ImportLists,
+    const FunctionImporter::ImportMapTy &ImportListsForModule,
     std::map<std::string, GVSummaryMapTy> &ModuleToSummariesForIndex);
----------------
tejohnson wrote:
> Suggest making the argument name here and in EmitImportsFiles "ImportList" to be consistent with some of the other places where a single module's import list is passed.
Done.
I also separately committed a renaming in all `FunctionImport.cpp` where `ImportListsForModule` was used multiple times (I initially took it from there).


Repository:
  rL LLVM

https://reviews.llvm.org/D23537





More information about the llvm-commits mailing list