[PATCH] D23474: COFF: add beginnings of debug directory creation

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.

================
Comment at: COFF/Debug.h:21
@@ +20,3 @@
+class DebugDirectoryContents {
+  std::vector<std::unique_ptr<Chunk>> DebugRecords;
+
----------------
ruiu wrote:
> ruiu wrote:
> > Move this after all public members for consistency with other class declarations.
> This class is a container of chunks, but only one element is currently added to this vector, so we don't actually need this class (you could add a member of type std::unique_ptr<CVDebugRecordChunk> to the Writer instead of this class.) Are you planning to do more complex thing with this class? If not, I'd remove this class.
Well, it should add a `coffgrp` record by default unless CV is present.  Furthermore, we should at some point emit the features record as well.  Ideally, at some point, this would also integrate into the PDB handling to retrieve the GUID and Age so that rather than re-generating it on every build, we could just increment the age.

I don't think that all of this will happen immediately, but is something that we will need, so I was tempted to create the class.  I don't think that Im really tied to that idea and i you think going with the simpler route for now is better, I can merge this into the writer.


Repository:
  rL LLVM

https://reviews.llvm.org/D23474