[llvm] r278659 - [Thumb] Validate branch target for CBZ/CBNZ instructions.

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 15 12:13:59 PDT 2016


This patch isn't quite right, there's another patch in review at
https://reviews.llvm.org/D23501 to correct it. I'd suggest reverting
this one for now if it is causing problems.

Oliver

On 15 August 2016 at 19:26, Renato Golin via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> On 15 August 2016 at 19:14, Reid Kleckner via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> How can we avoid this error? Shouldn't LLVM be responsible for relaxing this
>> into some other code sequence?
>
> I believe so.
>
> From what I can see, this is not a hand-written assembly, but a C code
> that somehow uses CBZ to branch either backwards, or at an odd or too
> far offset. This is clearly a codegen error on LLVM's side and a bug
> should be filled in LLVM's Bugzilla, too.
>
> I don't know how you could work around this in that case, but the
> check is correct, so reverting it would be bad. But a temporary
> revert, until we find the codegen bug would be totally acceptable,
> IMO.
>
> cheers,
> --renato
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list