[llvm] r278711 - Revert "[Thumb] Validate branch target for CBZ/CBNZ instructions."

[Matthias Braun via llvm-commits]

Author: matze
Date: Mon Aug 15 13:50:13 2016
New Revision: 278711

URL: http://llvm.org/viewvc/llvm-project?rev=278711&view=rev
Log:
Revert "[Thumb] Validate branch target for CBZ/CBNZ instructions."

This currently breaks the greendragon clang-stage1-configure-RA/ and
brotli. It is probably just uncovering a pre-existing problem. Reverting
temporarily to get the buildbots green again. A reduced testcase will
follow shortly.

This reverts commit r278659.

Removed:
    llvm/trunk/test/MC/ARM/thumb-cb-negative-offsets.s
Modified:
    llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
    llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
    llvm/trunk/test/MC/ARM/thumb-diagnostics.s

Modified: llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp?rev=278711&r1=278710&r2=278711&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp Mon Aug 15 13:50:13 2016
@@ -6684,12 +6684,6 @@ bool ARMAsmParser::validateInstruction(M
       return Error(Operands[Op]->getStartLoc(), "branch target out of range");
     break;
   }
-  case ARM::tCBZ:
-  case ARM::tCBNZ: {
-    if (!static_cast<ARMOperand &>(*Operands[2]).isUnsignedOffset<6, 1>())
-      return Error(Operands[2]->getStartLoc(), "branch target out of range");
-    break;
-  }
   case ARM::MOVi16:
   case ARM::t2MOVi16:
   case ARM::t2MOVTi16:

Modified: llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp?rev=278711&r1=278710&r2=278711&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp (original)
+++ llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp Mon Aug 15 13:50:13 2016
@@ -578,11 +578,6 @@ unsigned ARMAsmBackend::adjustFixupValue
     // Offset by 4, and don't encode the low two bits.
     return ((Value - 4) >> 2) & 0xff;
   case ARM::fixup_arm_thumb_cb: {
-    // CB instructions can only branch to offsets in [0, 126] in multiples of 2
-    if (Ctx && ((int64_t)Value < 0 || Value > 0x3e || Value & 1)) {
-      Ctx->reportError(Fixup.getLoc(), "out of range pc-relative fixup value");
-      return 0;
-    }
     // Offset by 4 and don't encode the lower bit, which is always 0.
     // FIXME: diagnose if no Thumb2
     uint32_t Binary = (Value - 4) >> 1;

Removed: llvm/trunk/test/MC/ARM/thumb-cb-negative-offsets.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/thumb-cb-negative-offsets.s?rev=278710&view=auto
==============================================================================
--- llvm/trunk/test/MC/ARM/thumb-cb-negative-offsets.s (original)
+++ llvm/trunk/test/MC/ARM/thumb-cb-negative-offsets.s (removed)
@@ -1,19 +0,0 @@
-@ RUN: not llvm-mc -triple thumbv7m-none-eabi      -filetype=obj -o /dev/null %s 2>&1 | FileCheck %s
-@ RUN: not llvm-mc -triple thumbv8m.base-none-eabi -filetype=obj -o /dev/null %s 2>&1 | FileCheck %s
-
-label0:
-  .word 4
-
-@ CHECK: out of range pc-relative fixup value
-  cbz r0, label0
-@ CHECK: out of range pc-relative fixup value
-  cbnz r0, label0
-
-@ CHECK: out of range pc-relative fixup value
-  cbz r0, label1
-@ CHECK: out of range pc-relative fixup value
-  cbnz r0, label1
-
-  .space 1000
-label1:
-  .word 4

Modified: llvm/trunk/test/MC/ARM/thumb-diagnostics.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/thumb-diagnostics.s?rev=278711&r1=278710&r2=278711&view=diff
==============================================================================
--- llvm/trunk/test/MC/ARM/thumb-diagnostics.s (original)
+++ llvm/trunk/test/MC/ARM/thumb-diagnostics.s Mon Aug 15 13:50:13 2016
@@ -235,23 +235,6 @@ error: invalid operand for instruction
 @ CHECK-ERRORS: error: branch target out of range
 
 @------------------------------------------------------------------------------
-@ CBZ/CBNZ - out of range immediates for branches
- at ------------------------------------------------------------------------------
-
-        cbz    r0, #-2
-        cbz    r0, #0
-        cbz    r0, #17
-        cbnz   r0, #126
-        cbnz   r0, #128
-
-@ CHECK-ERRORS-V7M: error: branch target out of range
-@ CHECK-ERRORS-V7M: error: invalid operand for instruction
-@ CHECK-ERRORS-V7M: error: branch target out of range
-@ CHECK-ERRORS-V8: error: branch target out of range
-@ CHECK-ERRORS-V8: error: invalid operand for instruction
-@ CHECK-ERRORS-V8: error: branch target out of range
-
- at ------------------------------------------------------------------------------
 @ SEV/WFE/WFI/YIELD - are not supported pre v6M or v6T2
 @------------------------------------------------------------------------------
         sev