[PATCH] D23502: [ELF] Linkerscript: discard .interp section if we have custom PHDRS layout and PT_INTERP is not listed.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/LinkerScript.cpp:489
@@ -488,1 +488,3 @@
 
+template <class ELFT> bool LinkerScript<ELFT>::discardInterpSection() {
+  // Discard .interp section in case we have PHDRS specification
----------------
`Discard` sounds like this function discards (or remove) an existing section from an output section list, so it's a bit confusing. I'd name `needsInterpSection`.


Repository:
  rL LLVM

https://reviews.llvm.org/D23502