[PATCH] D22952: [LoopVectorize] Detect loops in the innermost loop before creating InnerLoopVectorizer

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 15:46:35 PDT 2016


timshen marked an inline comment as done.

================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4630-4634
@@ -4551,7 +4629,7 @@
 
   // We can only vectorize innermost loops.
   if (!TheLoop->empty()) {
     emitAnalysis(VectorizationReport() << "loop is not the innermost loop");
     return false;
   }
 
----------------
anemet wrote:
> Please add a FIXME, that this code is dead too as we discovered (unless you will remove it in a quick follow-up).
I added a FIXME, since it's unclear to me if it's a good idea to remove things from canVectorize() - this function seems to do all kinds of centralized checking, regardless of the caller side situation.

I'll leave the potential actual removal in the future, possibly after a discussion.


https://reviews.llvm.org/D22952





More information about the llvm-commits mailing list