[PATCH] D23460: [NVPTX] Use untyped (.b) integer registers in PTX.

[Artem Belevich via llvm-commits]

tra added inline comments.

================
Comment at: test/CodeGen/NVPTX/reg-types.ll:25
@@ +24,3 @@
+
+; It's hard to check that we *didn't* generate .reg .b8 above.
+; We'll check that we use 16-bit registers for 8-bit stores.
----------------
jlebar wrote:
> I don't know what you're trying to check, but you can't do CHECK-NOT?
I need to make sure we did not generate `.reg .b8` for a register we use to store something in `%u8/%s8`.
Instead, we expect generate `.reg .b16`. However, `.reg .b16` is also used for operations on 16-bit `%s16`/`%u16`, so checking for its existence does not rule out `.reg .b8`. CHECK-NOT would work, if order of `.reg` would be guaranteed, but it's not.

According to [[ http://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive | FileCheck manual ]], CHECK-DAG entries around CHECK-NOT cannot be reordered. Considering that .reg lines are not ordered, placing CHECK-NOT anywhere in-between CHECK-DAG lines would break the tests.





https://reviews.llvm.org/D23460