[lld] r278480 - [ELF][MIPS] Fix the comment

[Rui Ueyama via llvm-commits]

Thanks!

On Thu, Aug 11, 2016 at 10:43 PM, Simon Atanasyan via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: atanasyan
> Date: Fri Aug 12 00:43:42 2016
> New Revision: 278480
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278480&view=rev
> Log:
> [ELF][MIPS] Fix the comment
>
> Modified:
>     lld/trunk/ELF/Mips.cpp
>
> Modified: lld/trunk/ELF/Mips.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Mips.
> cpp?rev=278480&r1=278479&r2=278480&view=diff
> ============================================================
> ==================
> --- lld/trunk/ELF/Mips.cpp (original)
> +++ lld/trunk/ELF/Mips.cpp Fri Aug 12 00:43:42 2016
> @@ -252,12 +252,15 @@ static StringRef getArchName(uint32_t Fl
>    }
>  }
>
> -// There are (arguably too) many MIPS ISAs out there. Some are compatible
> -// with each other and some are not. This function checks if all input
> -// files are compatible with each other, and if so, returns the "lowest"
> -// ISA flag. For example, if one object is in EF_MIPS_ARCH_3 and the
> -// other is in EF_MIPS_ARCH_2, it'll return EF_MIPS_ARCH_2 because it's
> -// older than EF_MIPS_ARCH_3.
> +// There are (arguably too) many MIPS ISAs out there. Their relationships
> +// can be represented as a forest. If all input files have ISAs which
> +// reachable by repeated proceeding from the single child to the parent,
> +// these input files are compatible. In that case we need to return
> "highest"
> +// ISA. If there are incompatible input files, we show an error.
> +// For example, mips1 is a "parent" of mips2 and such files are
> compatible.
> +// Output file gets EF_MIPS_ARCH_2 flag. From the other side mips3 and
> mips32
> +// are incompatible because nor mips3 is a parent for misp32, nor mips32
> +// is a parent for mips3.
>  static uint32_t getArchFlags(ArrayRef<FileFlags> Files) {
>    uint32_t Ret = Files[0].Flags & (EF_MIPS_ARCH | EF_MIPS_MACH);
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160812/7d860554/attachment.html>