[PATCH] D21960: [Sparc] Leon errata fixes passes.

Chris Dewhurst via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 12 08:13:42 PDT 2016


lero_chris added a comment.

In https://reviews.llvm.org/D21960#513813, @jyknight wrote:

> In https://reviews.llvm.org/D21960#513655, @lero_chris wrote:
>
> > Hi Daniel. Nobody was commenting and I need to get this checked-in as I won't be around for three weeks now. You commented at *exactly* the same time as I did the check-in. Otherwise, I had addressed all the review comments.
> >
> > I'll look at the comments and make any necessary changes when I am next at work.
>
>
> This is not OK. You have ignored two requests for a revert in a row now. I have reverted all of this in r278511.


Sorry James. I had been addressing the comments. I hadn't realised that "revert" meant rolling back the repository changes too. SVN isn't something I use much and the language differs somewhat between source control systems.

I'll abandon this review and start a new review, albeit that this is all working and tested now.


Repository:
  rL LLVM

https://reviews.llvm.org/D21960





More information about the llvm-commits mailing list